Missing signature violation warnings suck
I've been working on some code, while developing on PHP 5.3. The code resembles the following structure:
<?php
interface ezcSearchQuery
{
public function limit( $limit, $offset = '' );
}
interface ezcSearchFindQuery extends ezcSearchQuery
{
}
class ezcSearchFindQuerySolr implements ezcSearchFindQuery
{
public function limit( $limit = 10, $offset = 0 )
{
$this->limit = $limit;
$this->offset = $offset;
}
}
?>
No problems at all while development, no warnings, no errors. Now when I deployed this on a PHP 5.2 machine it bombed out, with the following correct message:
Fatal error: Declaration of ezcSearchFindQuerySolr::limit() must be compatible with that of ezcSearchQuery::limit() in /tmp/index.php on line 11
And this really sucks. I made a mistake in my code (wrongly implemented interface) and I get no warning (not even E_STRICT)... and then deploy it and it bails out on me. We can't have this. We need warnings (actually, it should be E_FATAL) for those cases in order to avoid problems. I don't know how this check got removed, but it should be put back in ASAP!
Comments
this code throws a Fatal error under 5.2.5 and also under 5.2.6-RC3 for me so whats the problem?
@Marco: The problem is that there is no warning at all in PHP 5.3.
The problem is, that this has been changed in 5.3.
Actually there's nothing wrong with different parameters in an implemented method. It's something you won't want to do often but you will want to do it and so this categorically should not cause a fatal error. The language should not attempt to impose misguided rules upon us.
"while developing on PHP 5.3."
@Marco: read, read and read again :P "while developing on PHP 5.3" != "when I deployed this on a PHP 5.2 machine" :)
It sounds like an interesting feature to me, in 5.3. It kind of brings about a BC break, and from that point of view, the different error levels sounds acceptable. That said, i guess this should be better signified as one of the 5.2 -> 5.3 migration tricks. And the question of having properly discussed this feature on the php core mailing list prior to implementing it is yet another issue :)
Life Line
Created a bench and a crossing
Created 2 benches and a crossing; Updated 5 cushions, a post_box, and a crossing
Created a crossing; Updated a cushion
If you were wondering whether the www.php.net & downloads.php.net services weren't responding very well in the last 6 hours — thousands of requests/sec to https://www.php.net/ 's root.
The server's load was 720, didn't die, but CDN connections to it timed out.
Now there is a caching strategy in place for a selected set of resources.
Updated a bench
Created 3 benches; Updated 10 benches
Updated a bench
Updated a bus_stop
Created a bench and a waste_basket; Updated 6 bus_stops and a crossing
Created 2 waste_baskets and a recycling; Updated 2 bicycle_parkings and a recycling
Updated a fast_food, a funeral_directors shop, and 2 other objects; Confirmed a fast_food and a hairdresser shop
Created an information; Updated 3 benches and 2 waste_baskets
Updated 2 benches and a waste_basket
Updated a bench
Created a waste_basket and an information
Created a waste_basket
I hiked 18.0km in 4h1m52s
I walked 1.4km in 17m19s
I walked 4.5km in 1h21m49s
I just made and ate, a bowl full of bacon fried Brussels Sprouts. Not under duress, and out of my own free will.
#winning #food #BrusselsSprouts
Added new residential building
Created a hairdresser shop; Confirmed a convenience shop and a dry_cleaning shop
Created a building_materials shop, a vacant shop, and 4 other objects; Confirmed a hairdresser shop, a cafe, and 2 other objects
I walked 8.3km in 1h33m44s
Shortlink
This article has a short URL available: https://drck.me/msvws-6ah