Figuring Out Foreach
For a while I have been aware of some odd behaviour when you use branch coverage with PHP's foreach language construct. Usually with PHPUnit.
Take for example this bit of code:
<?php
function showLanguages(array $languages): void
{
foreach ($languages as $language) {
echo $language, "\n";
}
}
It seems that in order to cover all paths by test cases to pass in an array without any elements, and one with at least one element.
But no, when you run the analysis, you will see that there only two out of the three paths are covered:
Let's first actually analyse which opcodes, PHP's internal execution units, are generated by the engine:
line #* E I O op return operands
------------------------------------------------
2 0 E > RECV !0
4 1 EXT_STMT
2 > FE_RESET_R $2 !0, ->9
3 > > FE_FETCH_R $2, !1, ->9
5 4 > EXT_STMT
5 ECHO !1
6 EXT_STMT
7 ECHO '%0A'
4 8 > JMP ->3
9 > FE_FREE $2
7 10 EXT_STMT
11 > RETURN null
This output from VLD shows on line 4, two relevant opcodes: FE_RESET_R and FE_FETCH_R. Both of them can either followed by the next opcode on the list, or they can jump (->9) to opcode 9, which marks the end of the loop.
However from the diagram above, we don't see that path (the green one) being taken. Only the two paths that both continue with the next opcode (the red and blue lines). It seems that the emptiness of a normal array is checked by the FE_FETCH_R opcode.
Now the question is how to trigger the other path, so that 100% path (and branch) coverage can be reached.
This turns out harder than it is. I originally thought that this would be possible by trying to create a broken iterator — for example one where you inherit from an internal class with a custom one, and not call the original constructor. But this creates an exception which pre-empts the engine from even running the rest of the function.
The only situation where I managed to do this was by creating an iterator that after a correct initialisation, had no items to return. An example of such as case is a DatePeriod iterator where the start date of the iterator is behind the end date:
$i1 = new DatePeriod(
new DateTimeImmutable("2025-01-14"),
DateInterval::createFromDateString("+1 day"),
new DateTimeImmutable("2025-01-01")
);
I had to change the definition of showLanguages too so that it accepts DatePeriod besides just array. But with that done, this specific iterator now lights up the green path:
There is currently an open bug in Xdebug's issue tracker to merge the branch analysis information for the two subsequent opcodes (FE_RESET_R and FE_FETCH_R).
I think I will now rather hide the jump away from the FE_RESET_R (and FE_RESET_RW) opcode.
But at last I now have an explanation as to where this phantom path came from.
Life Line
Created a vending_machine
Updated a bus_stop
I hiked 5.4km in 2h35m46s
I walked 2.2km in 27m13s
I walked 1.6km in 32m29s
I walked 3.3km in 34m33s
Updated a confectionery shop, a massage shop, and 2 other objects; Deleted a books shop
I hiked 7.0km in 4h21m00s
Updated a deli shop and a pet_grooming shop
I walked 4.2km in 49m42s
I walked 1.4km in 10m14s
I walked 2.2km in 1h43m13s
I walked 4.4km in 1h25m00s
Updated a cafe
Updated a bar
I walked 1.7km in 19m07s
I got a new lens. It's a little bit larger, and loads heavier, than my older one.
I walked 1.6km in 15m10s
Updated a pub
I walked 4.5km in 41m34s
Merge branch 'v2022'
Merge branch 'isspace-fixes' into v2022
Cast to 'unsigned char' for all ctype style functions (isspace, toupp…
I saw a Kingfisher fishing yesterday!
It's not a great photo, but it was great seeing it using the branch as a perch for fishing.




Shortlink
This article has a short URL available: https://drck.me/fidgety-forach-jbc