PHP's two-pass compiler
On my way to Istanbul I was looking at Xdebug bug #422 . For some reason Xdebug was crashing while doing code-coverage analysis, in the part that analyses which code was dead (ie. opcodes that could never be reached). The crash occurred with a JMPZ (jump-if-zero) instruction, that suddenly saw a jump-to position of 572222864. That position resembles more a jump-address.
Xdebug uses the same branch analysis implementation as VLD so I used the latter tool to find out why it would crash. Unfortunately, it was working just all nice and fine with VLD. After digging around some more, I saw from the back trace that the crash in Xdebug only occurred when a user-defined error-handler was called while parsing a file. The latter gave me the insight of looking at which phase the compiler was in. I remembered that PHP has a two phase compiler. The first pass is quick and dirty, and only records the opcode line number to jump to. Xdebug however was expecting an memory address as jump target. Because a memory address is a much larger number than an opcode number—the latter usually not being much higher than a thousand—Xdebug was setting the "visited" flag in a part of memory that wasn't allocated. And writing to unallocated memory makes a process die with a segmentation fault.
The compiler in PHP is two-pass. During the first pass, it will find out to which opcode it needs to jump in the jump instructions. However, the PHP engine (and Xdebug) expects a memory address to jump to while executing your script. In the second pass, the compiler will then go over the generated opcodes and calculate the memory address to jump to from the jumps to opcode numbers. It will also do a few other things, such as collapsing sequential EXT_STMT opcodes, calling Zend extension's functions to finalize the opcode arrays—Xdebug uses this for caching whether an opcode array has been scanned already—and re-allocating the opcode array itself to save space.
Now, the thing is, that usually VLD and Xdebug kick in after the whole opcode array has been created, which includes running the second pass of the compiler. However, Xdebug also tries to analyze opcode arrays while executing them. In the case of a user defined error handler, that happens before the second pass has been run. Preventing the crash was therefore as easy as making sure that the compiler's second pass had been run while scanning the opcode arrays for executable code.
Life Line
I walked 1.6km in 16m19s
Updated a restaurant
I walked 8.0km in 1h27m42s
Merged pull request #1074
Bump actions/download-artifact from 6 to 8
Merged pull request #1073
Bump actions/upload-artifact from 6 to 7
Merged pull request #1072
Bump geekyeggo/delete-artifact from 5 to 6
Merge branch 'v2022'
Merge pull request #173 from LukasGelbmann/lukasgelbmann/fix-year-0
Having a sleep after learning how to create value.
#goose #EgyptianGoose #BirdPhotography #Photography #BirdsOfFediverse
I walked 4.3km in 51m10s
I walked 1.1km in 9m55s
I walked 5.4km in 1h40m50s
Look at me being cool!
A crested tit sits on a branch among some leaves.
#BirdPhotogaphy #BirdsOfMastodon #Birds #photography #aves #TheNetherlands #nature
I walked 5.4km in 53m36s
I walked 8.8km in 2h9m08s
Created a veterinary
I walked 4.6km in 1h12m09s
I walked 0.8km in 9m29s
Updated 2 waste_baskets
Updated a pub
Updated a pub; Confirmed an ice_cream
Updated a fast_food and a pub



Shortlink
This article has a short URL available: https://drck.me/ptc-6za