Missing signature violation warnings suck
I've been working on some code, while developing on PHP 5.3. The code resembles the following structure:
<?php
interface ezcSearchQuery
{
public function limit( $limit, $offset = '' );
}
interface ezcSearchFindQuery extends ezcSearchQuery
{
}
class ezcSearchFindQuerySolr implements ezcSearchFindQuery
{
public function limit( $limit = 10, $offset = 0 )
{
$this->limit = $limit;
$this->offset = $offset;
}
}
?>
No problems at all while development, no warnings, no errors. Now when I deployed this on a PHP 5.2 machine it bombed out, with the following correct message:
Fatal error: Declaration of ezcSearchFindQuerySolr::limit() must be compatible with that of ezcSearchQuery::limit() in /tmp/index.php on line 11
And this really sucks. I made a mistake in my code (wrongly implemented interface) and I get no warning (not even E_STRICT)... and then deploy it and it bails out on me. We can't have this. We need warnings (actually, it should be E_FATAL) for those cases in order to avoid problems. I don't know how this check got removed, but it should be put back in ASAP!
Comments
this code throws a Fatal error under 5.2.5 and also under 5.2.6-RC3 for me so whats the problem?
@Marco: The problem is that there is no warning at all in PHP 5.3.
The problem is, that this has been changed in 5.3.
Actually there's nothing wrong with different parameters in an implemented method. It's something you won't want to do often but you will want to do it and so this categorically should not cause a fatal error. The language should not attempt to impose misguided rules upon us.
"while developing on PHP 5.3."
@Marco: read, read and read again :P "while developing on PHP 5.3" != "when I deployed this on a PHP 5.2 machine" :)
It sounds like an interesting feature to me, in 5.3. It kind of brings about a BC break, and from that point of view, the different error levels sounds acceptable. That said, i guess this should be better signified as one of the 5.2 -> 5.3 migration tricks. And the question of having properly discussed this feature on the php core mailing list prior to implementing it is yet another issue :)
Life Line
Created 2 waste_baskets; Updated 2 bus_stops and 2 crossings
I hate this timeline.
For @fridaynightdinners I wanted to look up what the difference between Raviolo and Girasolo is.
DuckDuckGo's (non-ai variant) top three results are all AI generated content with AI generated author images, bio, and "flair".
I want stuff written by *humans*, not this AI slop BS.
Created 3 waste_baskets; Updated a waste_basket
Updated 6 crossings
Northern Lapwing On The Move
This dapper bird is having a stroll looking for lunch. I like the iridescence in its wings.
#BirdPhotography #BirdsOfFediverse #Nature #Photography #London #BirdsOfMastodon
Created a vending_machine
Updated a bus_stop
I hiked 5.4km in 2h35m46s
I walked 2.2km in 27m13s
I walked 1.6km in 32m29s
I walked 3.3km in 34m33s
Updated a confectionery shop, a massage shop, and 2 other objects; Deleted a books shop
I hiked 7.0km in 4h21m00s
Updated a deli shop and a pet_grooming shop
I walked 4.2km in 49m42s
I walked 1.4km in 10m14s
I walked 2.2km in 1h43m13s
I walked 4.4km in 1h25m00s
Updated a cafe
Updated a bar
I walked 1.7km in 19m07s
I got a new lens. It's a little bit larger, and loads heavier, than my older one.
#photography #naturephotography
I walked 1.6km in 15m10s
Shortlink
This article has a short URL available: https://drck.me/msvws-6ah