Contributing Advent 9: Day of the week

Monday, December 9th 2013, 09:10 GMT

London, UK

This is another one in the Date/Time extension series. Bugs #63391 and #61599 both deal with PHP getting the Day of Week wrong in years before 1600. Technically I did not write the patch for this contribution, but I did add tests, verified it and merged it to all the four branches (PHP 5.4, 5.5, 5.6 and master).

However, it does seem that I introduced the bug in the first place. When writing the new date/time support about 7 years ago I was looking for an algorithm that would tell me the day of the week for any given (Gregorian calendar) date. Wikipedia has quite a good article on it. The article outlines the calculation of the century number. For the Gregorian calendar, that's quite straight forwards: 6 - (j % 4) * 2. For the Julian calendar it's not very difficult either. Although PHP uses the proleptic Gregorian calendar that I wrote about before, I mistakenly had used a formula that combined the Julian and Gregorian calendar calculations. This then resulted in wrong calculations before the year 1600. This is now corrected and ready for inclusion into PHP 5.4.24, 5.5.7, and later versions.

Become a Patron!

Shortlink

This article has a short URL available: https://drck.me/adv1309-af1

Comments

No comments yet

Add Comment

Name:
Email:	Will not be posted. Please leave empty instead of filling in garbage though!
Comment:	Please follow the reStructured Text format. Do not use the comment form to report issues in software, use the relevant issue tracker. I will not answer them here.
	All comments are moderated

Become a Patron!

My Amazon wishlist can be found here.

Human-Made Webring
previous | random | next

Life Line

Created a chocolate shop and a restaurant; Updated 6 restaurants and an address; Confirmed 5 restaurants, a community_centre, and 3 other objects

51.51° N, 0.12° W — osm — Jul 24th, 19:17 UTC
Created a restaurant, a fast_food, and 2 other objects; Deleted a restaurant

51.51° N, 0.12° W — osm — Jul 24th, 19:10 UTC
I walked 8.5km in 1h31m45s

runkeeper — Jul 24th, 16:38 UTC
Created 2 buildings and a hairdresser shop; Updated a restaurant and an estate_agent office; Confirmed a cafe

51.54° N, 0.19° W — osm — Jul 24th, 12:33 UTC
I walked 2.2km in 38m09s

runkeeper — Jul 24th, 12:06 UTC
Merged pull request #1096

github:xdebug/xdebug — Jul 24th, 09:51 UTC
Bump actions/checkout from 6 to 7

github:xdebug/xdebug — Jul 24th, 09:51 UTC
Merged pull request #1095

github:xdebug/xdebug — Jul 24th, 09:51 UTC
Improve Tiverton Green mapping

51.54° N, 0.22° W — osm — Jul 23rd, 12:29 UTC
Created 2 gates

51.54° N, 0.22° W — osm — Jul 23rd, 10:25 UTC
I walked 7.1km in 1h23m15s

runkeeper — Jul 23rd, 09:25 UTC
I walked 1.0km in 9m24s

runkeeper — Jul 23rd, 08:11 UTC
I've just finished reading Star Ship Troopers.
#Reading #BookList2026

mastodon — Jul 22nd, 21:59 UTC
Realign streets. They now have much less wide corners into each other.

51.54° N, 0.17° W — osm — Jul 22nd, 12:31 UTC
Updated a fast_food

51.54° N, 0.19° W — osm — Jul 22nd, 12:09 UTC
I walked 9.1km in 1h35m41s

runkeeper — Jul 22nd, 12:03 UTC
I hiked 4.7km in 3h24m10s

runkeeper — Jul 21st, 09:18 UTC
I walked 6.7km in 1h12m03s

runkeeper — Jul 19th, 16:34 UTC
I walked 7.7km in 1h47m24s

runkeeper — Jul 19th, 09:49 UTC
Updated a pub

44.50° N, 11.33° E — osm — Jul 18th, 21:03 UTC
Updated a pub

44.50° N, 11.33° E — osm — Jul 18th, 19:37 UTC
Created a bar; Updated a bar; Confirmed a restaurant and a bar

44.50° N, 11.34° E — osm — Jul 18th, 17:09 UTC
I walked 8.1km in 4h3m56s

runkeeper — Jul 18th, 15:36 UTC
Updated a toilet

44.84° N, 11.62° E — osm — Jul 18th, 12:41 UTC
I walked 8.8km in 2h52m21s

runkeeper — Jul 18th, 09:45 UTC